Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Entrypoints Port Address without protocol for redirect #7047

Conversation

SantoDE
Copy link
Collaborator

@SantoDE SantoDE commented Jul 14, 2020

What does this PR do?

Takes the entrypoints address without the protocol for the entrypoint based redirection.

Motivation

Fix traefik/traefik-helm-chart#208

More

  • Added/updated tests
  • [ ] Added/updated documentation

Additional Notes

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix_ep_based_redirect_with_protocol_qualified_port branch from af01b33 to d7197be Compare July 16, 2020 14:58
@traefiker traefiker merged commit fae2d93 into traefik:v2.2 Jul 16, 2020
v2 automation moved this from To review to Done Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants