Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean X-Forwarded-Prefix header for the dashboard. #7109

Merged
merged 3 commits into from Jul 28, 2020
Merged

fix: clean X-Forwarded-Prefix header for the dashboard. #7109

merged 3 commits into from Jul 28, 2020

Conversation

ldez
Copy link
Member

@ldez ldez commented Jul 27, 2020

What does this PR do?

Clean X-Forwarded-Prefix header for the dashboard.

Motivation

Be safe.

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 2.2 milestone Jul 27, 2020
@ldez ldez added this to To review in v2 via automation Jul 27, 2020
dtomcej
dtomcej reviewed Jul 27, 2020
View reviewed changes
pkg/api/dashboard_test.go Outdated Show resolved Hide resolved
rtribotte
rtribotte approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

jbdoumenjou
jbdoumenjou approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit e63db78 into traefik:v2.2 Jul 28, 2020
v2 automation moved this from To review to Done Jul 28, 2020
@ldez ldez deleted the fix/dashboard-prefix branch July 28, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej left review comments

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@mmatur mmatur mmatur approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/webui kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ldez @jbdoumenjou @mmatur @dtomcej @rtribotte @traefiker