Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-crd: fix whitespace in configuration examples #7134

Merged
merged 1 commit into from Aug 3, 2020
Merged

kubernetes-crd: fix whitespace in configuration examples #7134

merged 1 commit into from Aug 3, 2020

Conversation

NT-florianernst
Copy link
Contributor

With the whitespace as it was the whole spec would be part of the
resource metadata which obviously won't yield the desired results.

What does this PR do?

The configuration examples in the kubernetes-crd part contain erroneous whitespace, making the whole spec part of the resource metadata. As such, these examples cannot be used as-is as the desired rules never become effective.

This PR fixes the whitespace so the examples can be used.

Motivation

Low-hanging fruit to help others taking their first steps with kubernetes-crd.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

None.

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

With the whitespace as it was the whole spec would be part of the
resource metadata which obviously won't yield the desired results.
@traefiker traefiker merged commit 3214904 into traefik:v2.2 Aug 3, 2020
v2 automation moved this from To review to Done Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants