Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: specify HostSNI rule removal only for HTTP routers #7237

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

rtribotte
Copy link
Member

What does this PR do?

This PR fix the documentation to avoid misleading assumptions when reading the HostSNI rule removal section in the migration guide, by specifying the scope of the removal of the HostSNI rule to HTTP routers only.

Motivation

closes #7229

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@rtribotte rtribotte added kind/enhancement a new or improved feature. area/documentation status/2-needs-review bot/light-review decreases the number of required LGTM from 3 to 1. labels Sep 2, 2020
@rtribotte rtribotte added this to the 2.2 milestone Sep 2, 2020
@rtribotte rtribotte added this to To review in v2 via automation Sep 2, 2020
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit f3090a4 into traefik:v2.2 Sep 2, 2020
v2 automation moved this from To review to Done Sep 2, 2020
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Sep 2, 2020
@rtribotte rtribotte deleted the fix/doc-hostsni-removal branch September 15, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants