Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ingressclass resource in the ingress RBAC documentation #7290

Merged
merged 1 commit into from Sep 15, 2020

Conversation

jbdoumenjou
Copy link
Member

@jbdoumenjou jbdoumenjou commented Sep 15, 2020

What does this PR do?

Add the ingressclass resource and the networking.k8s.io apiGroup to the RBAC.

Motivation

Have an up to date documentation.

related to #7199 and #7083

More

  • Added/updated tests
  • Added/updated documentation

@jbdoumenjou jbdoumenjou added area/documentation bot/light-review decreases the number of required LGTM from 3 to 1. status/2-needs-review and removed status/0-needs-triage labels Sep 15, 2020
@jbdoumenjou jbdoumenjou added this to To review in v2 via automation Sep 15, 2020
@jbdoumenjou jbdoumenjou added this to the 2.3 milestone Sep 15, 2020
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

@traefiker traefiker merged commit 9df89e6 into traefik:v2.3 Sep 15, 2020
v2 automation moved this from To review to Done Sep 15, 2020
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Sep 15, 2020
@jbdoumenjou jbdoumenjou deleted the ingress-doc branch September 15, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants