Forward Proxy-Authorization header to authentication server #7433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
changed the title
jbdoumenjou
added
status/1-needs-design-review
and removed
status/0-needs-triage
labels
|
@kevinpollet @jbdoumenjou Anything blocking or is it just the lack of time ? |
|
Hello @Scapal, sorry for a long time no answer. As you can see in our contribution guide, We will come back to you soon when we did the first design review iteration. |
kevinpollet
added
status/2-needs-review
and removed
status/1-needs-design-review
labels
kevinpollet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes issue #7374 and related to the ForwardAuth middleware header filtering behaviour.
It allows the
Proxy-Authorizationheader to be forwarded to the Authentication service.It also fixes a potential issue with the
authRequestHeadersoption, skipping header filtering if an explicit header list is given.Motivation
I am using Traefik 2 with Authelia using ForwardAuth.
Authelia expects the authentication header
Proxy-Authorizationfor proxy authentication but it is currently removed when the request if sent to the authentication service as it is considered a "hop" header.Without modification we are unable to use this setup to protect APIs.
fixes #7374
More
Additional Notes