Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grammar in kubernetes ingress controller documentation #7565

Merged
merged 1 commit into from Nov 19, 2020
Merged

Fix grammar in kubernetes ingress controller documentation #7565

merged 1 commit into from Nov 19, 2020

Conversation

ivorscott
Copy link

@ivorscott ivorscott commented Nov 19, 2020 •
edited by rtribotte

What does this PR do?

fix grammar

Motivation

More

  • [ ] Added/updated tests
  • Added/updated documentation

Additional Notes

@kevinpollet kevinpollet added this to the 2.3 milestone Nov 19, 2020
@kevinpollet kevinpollet added this to To review in v2 via automation Nov 19, 2020
rtribotte
rtribotte approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

jbdoumenjou
jbdoumenjou approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kevinpollet kevinpollet changed the title Update kubernetes-ingress.md Fix grammar in kubernetes ingress controller documentation Nov 19, 2020
kevinpollet
kevinpollet approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@traefiker traefiker merged commit 9fb32a4 into traefik:v2.3 Nov 19, 2020
v2 automation moved this from To review to Done Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ivorscott @kevinpollet @jbdoumenjou @rtribotte @traefiker