Use sdnotify for systemd #768
Conversation
This is useful if a configuration is long to load. Systemd will continue dependency chain only when server have finish to start. https://www.freedesktop.org/software/systemd/man/systemd.service.html#Type=
|
After a night of reflection... I think we can do a better design :) |
|
Main problem is server.Start() is a blocking function. I can't evaluate when it finish to listen on socket etc. |
|
Changes can be squashed and pushed with 1-clic |
|
Many thanks to @nikkau ! |
| defer server.Close() | ||
| sent, err := daemon.SdNotify("READY=1") |
There was a problem hiding this comment.
Don't you need to call server.Start() before?
There was a problem hiding this comment.
Seems a good idea :) .
Sorry, bad C/C.
There was a problem hiding this comment.
hopefully tests was there to protect us, but @emilevauge eyes are quite faster ;)
|
Let's squash the commit too if possible 👼 |
|
@vdemeester this can be done via GH button ;) |
|
@guilhem that's true, but I am not a huge fan of that 😸 — but let's do it 😝 |
|
@vdemeester this have 1 advantage: keeping history in PR. |
|
@guilhem hum yeah but sometimes you want to actually have a PR with multiples commit merged as is. Anyway, this is no big deal 😝 |
* Use sdnotify for systemd This is useful if a configuration is long to load. Systemd will continue dependency chain only when server have finish to start. https://www.freedesktop.org/software/systemd/man/systemd.service.html#Type= * Extract the waiting behavior from Start()
ldez
added
status/3-needs-merge
and removed
status/2-needs-review
status/1-needs-design-review
labels
This is useful if a configuration is long to load.
Systemd will continue dependency chain only when server have finish to start.
https://www.freedesktop.org/software/systemd/man/systemd.service.html#Type=