Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing doc for default value of checknewversion #7933

Merged
merged 3 commits into from Feb 26, 2021
Merged

Fixing doc for default value of checknewversion #7933

merged 3 commits into from Feb 26, 2021

Conversation

tomMoulard
Copy link
Member

@tomMoulard tomMoulard commented Feb 25, 2021 •
edited by ldez

What does this PR do?

Update the doc as the default value for CheckNewVersion is true:

traefik/cmd/configuration.go

Line 22 in 438eec7

CheckNewVersion: true,

More

- [ ] Added/updated tests

  • Added/updated documentation

Additional Notes

Fixes #7878

@ldez ldez added this to To review in v2 via automation Feb 26, 2021
@ldez ldez changed the base branch from master to v2.4 February 26, 2021 02:01
@ldez ldez added this to the 2.4 milestone Feb 26, 2021
@ldez ldez self-requested a review February 26, 2021 02:03
ldez
ldez approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rtribotte
rtribotte approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

kevinpollet
kevinpollet approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit c35a8bd into traefik:v2.4 Feb 26, 2021
v2 automation moved this from To review to Done Feb 26, 2021
@traefiker traefiker mentioned this pull request Feb 26, 2021
Closed
@tomMoulard tomMoulard deleted the checknewversion branch February 26, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.4
Development

Successfully merging this pull request may close these issues.

unwanted check new version
6 participants
@tomMoulard @kevinpollet @mmatur @ldez @rtribotte @traefiker