Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecates ssl redirect headers middleware options #8160

Merged
merged 1 commit into from May 28, 2021
Merged

Deprecates ssl redirect headers middleware options #8160

merged 1 commit into from May 28, 2021

Conversation

tomMoulard
Copy link
Member

@tomMoulard tomMoulard commented May 27, 2021 •
edited

What does this PR do?

Deprecates sslRedirect, sslTemporaryRedirect, sslHost and sslForceHost.

Motivation

Prepare the removal of support of these options.

For simple HTTP to HTTPS redirection, one should use EntryPoints redirections

For more advanced use cases, you can use either the RedirectScheme middleware or the RedirectRegex middleware.

More

  • Added/updated tests
  • Added/updated documentation

@tomMoulard tomMoulard changed the title Deprecations Deprecates header middleware options May 27, 2021
@tomMoulard tomMoulard changed the title Deprecates header middleware options Deprecates headers middleware options May 27, 2021
@ldez ldez added this to To review in v2 via automation May 27, 2021
@ldez ldez added this to the next milestone May 27, 2021
dtomcej
dtomcej reviewed May 27, 2021
View reviewed changes
docs/content/middlewares/headers.md Outdated Show resolved Hide resolved
docs/content/middlewares/headers.md Outdated Show resolved Hide resolved
docs/content/middlewares/headers.md Outdated Show resolved Hide resolved
docs/content/migration/v2.md Outdated Show resolved Hide resolved
@tomMoulard tomMoulard changed the title Deprecates headers middleware options Deprecates ssl redirect headers middleware options May 27, 2021
ldez
ldez approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

rtribotte
rtribotte approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@traefiker traefiker merged commit 5632ee6 into traefik:master May 28, 2021
v2 automation moved this from To review to Done May 28, 2021
@tomMoulard tomMoulard deleted the deprecations branch May 28, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/middleware kind/enhancement a new or improved feature. size/M
Projects
No open projects
v2
Done
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tomMoulard @ldez @dtomcej @rtribotte @traefiker