Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default file format for the snippets from TOML to YAML #8193

Merged
merged 2 commits into from Jun 18, 2021

Conversation

tomMoulard
Copy link
Member

What does this PR do?

Changing default file format in the documentation to have example in YML format first.

Motivation

Unified documentation

More

  • [ ] Added/updated tests
  • Added/updated documentation

Additional Notes

Also removed some trailing white space.

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to change ;-)

@tomMoulard tomMoulard force-pushed the doc/yml-first2 branch 3 times, most recently from b3df1ff to c2183ac Compare June 17, 2021 15:59
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tomMoulard tomMoulard force-pushed the doc/yml-first2 branch 3 times, most recently from aa5bb52 to 8e93e91 Compare June 18, 2021 13:30
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

tomMoulard and others added 2 commits June 18, 2021 21:50
Co-authored-by: Romain <rtribotte@users.noreply.github.com>
@traefiker traefiker merged commit c9df233 into traefik:v2.4 Jun 18, 2021
v2 automation moved this from To review to Done Jun 18, 2021
@tomMoulard tomMoulard deleted the doc/yml-first2 branch June 21, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants