Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traffic size metrics #8432

Closed
wants to merge 7 commits into from
Closed

Conversation

OmarElawady
Copy link
Contributor

@OmarElawady OmarElawady commented Sep 9, 2021

What does this PR do?

Adds bytes_sent and bytes_received metrics for all metric backends.

Motivation

We make a gateway solution based on traefik, and this metric is needed to know how much traffic was used by each service. And it may be useful for other use cases as well, also it would be great to have your feedback whether this is the correct way to calculate it.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

  • The relevant tests passes but the integration tests seems to fail at random unrelated tests each time.
  • The pilot backend seems to be missing the router metrics. By accident?

@kmskpraveen
Copy link

Any update on this? This is a very crucial metrics that will be helpful especially with load testing.

@rtribotte
Copy link
Member

Hello @kmskpraveen,

Thanks for your interest in Traefik and thanks @OmarElawady for your contribution!

This PR is labeled as needs-design-review,
as you can see in our contribution guide, this means that we have to take a longer look to evaluate how it would interact with the other parts of Traefik.

We will come back to you once the design review iteration is done.

@tomMoulard tomMoulard mentioned this pull request Jul 25, 2022
2 tasks
@tomMoulard
Copy link
Member

Hello @OmarElawady,

Thanks for your PR, I've worked a bit on this topic, and opened a new PR based on your work.

I'm closing this PR in favor of #9208.

@tomMoulard tomMoulard closed this Jul 25, 2022
v2 automation moved this from To review to Done Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants