Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golint in v1.1 #849

Merged
merged 1 commit into from Nov 16, 2016
Merged

Fix golint in v1.1 #849

merged 1 commit into from Nov 16, 2016

Conversation

emilevauge
Copy link
Member

Cherry pick b0efd68 from #848 into branch v1.1.

/cc @containous/traefik

recent additions to golint mean that a number of files cause the
build to start failing if they are edited (we only run against changed
files)

This fixes all the errors in the repo so things don't unexpectedly start
failing for people making PRs
@emilevauge emilevauge added this to the 1.1 milestone Nov 16, 2016
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilevauge emilevauge merged commit 801e0f9 into v1.1 Nov 16, 2016
@vdemeester vdemeester deleted the fix-golint-1.1 branch November 16, 2016 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants