Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple namespaces for Consul and ConsulCatalog providers #8979

Merged
merged 17 commits into from Jun 3, 2022

Conversation

rtribotte
Copy link
Member

@rtribotte rtribotte commented May 3, 2022

What does this PR do?

This PR adds the support for multiple namespaces configuration for the Consul and ConsulCatalog providers.

Motivation

Fixes #8896

To be more compliant with the Namespaces feature of Consul Enterprise.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: Kevin Pollet pollet.kevin@gmail.com

docs/content/providers/consul-catalog.md Outdated Show resolved Hide resolved
docs/content/providers/consul-catalog.md Show resolved Hide resolved
docs/content/providers/consul.md Outdated Show resolved Hide resolved
docs/content/providers/consul.md Show resolved Hide resolved
pkg/config/static/static_config.go Show resolved Hide resolved
pkg/provider/consulcatalog/consul_catalog.go Outdated Show resolved Hide resolved
Co-authored-by: Tom Moulard <tom@moulard.org>
pkg/provider/consulcatalog/consul_catalog.go Outdated Show resolved Hide resolved
pkg/provider/consulcatalog/consul_catalog.go Outdated Show resolved Hide resolved
pkg/provider/consulcatalog/consul_catalog.go Outdated Show resolved Hide resolved
pkg/provider/consulcatalog/consul_catalog.go Show resolved Hide resolved
pkg/provider/kv/consul/consul.go Show resolved Hide resolved
pkg/provider/consulcatalog/consul_catalog.go Outdated Show resolved Hide resolved
pkg/provider/consulcatalog/consul_catalog.go Outdated Show resolved Hide resolved
pkg/provider/kv/consul/consul.go Show resolved Hide resolved
pkg/provider/kv/consul/consul.go Outdated Show resolved Hide resolved
pkg/provider/kv/consul/consul.go Show resolved Hide resolved
kevinpollet and others added 5 commits June 2, 2022 12:11
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@CalebAlbers
Copy link

Hey traefik team!

Thanks for putting this functionality together. Is it likely that this PR will land in the next release candidate?

@ddtmachado
Copy link
Contributor

@CalebAlbers Yes, it will be there for 2.8 RC

@CalebAlbers
Copy link

@ddtmachado Fantastic, thanks for confirming! The team is looking forward to getting our hands on it 🚀

Copy link
Member

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@traefiker traefiker merged commit f90e381 into traefik:master Jun 3, 2022
v2 automation moved this from To review to Done Jun 3, 2022
0teh added a commit to 0teh/traefik that referenced this pull request Sep 14, 2022
kevinpollet pushed a commit to 0teh/traefik that referenced this pull request Sep 19, 2022
@rtribotte rtribotte deleted the multi-namespaces-consul branch June 12, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

Full Consul Namespace support
7 participants