Control allocation and copy of labelNamesValues type #9241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
force-pushed
the
fix-prometheus-labels-names-value
branch
from
df57f24
to
0914b8f
Compare
|
Just an off-hand comment but in my local testing where I confirmed the initial Prometheus metrics performance was fixed, this branch is actually showing an increase in perf vs. 2.8.1. I suspect there is some performance hit; but that it's largely offset by Golang 1.19. :) |
kevinpollet
added
status/2-needs-review
and removed
status/1-needs-design-review
labels
mpl
approved these changes
Aug 11, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes the
labelNamesValuestype method `With' not mutate the original slice, by doing an explicit copy.Motivation
Avoid potential metrics overlapping.
More
Additional Notes
This change needs to be benchmarked.
Co-authored-by: Kevin Pollet pollet.kevin@gmail.com