Log TLS client subject #9285
Merged
Log TLS client subject #9285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddtmachado
added
kind/enhancement
xmessi
force-pushed
the
log-tls-client-subject
branch
from
8bd7941
to
9efc7bd
Compare
rtribotte
force-pushed
the
log-tls-client-subject
branch
from
27e3174
to
fb68a8a
Compare
nmengin
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for logging the TLS client subject, when it is used (mTLS connections).
Motivation
In my use case, the TLS client subject contains a username; TLS client certificates are used to authenticate users. Logging this improves the traceability of actions performed, similar to the
ClientUsernamefield which is filled in case of HTTP Basic Auth.More
Additional Notes
Thanks for considering this PR for inclusion