Add support for Brotli #9387
Merged
Add support for Brotli #9387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomMoulard
added
kind/enhancement
ldez
changed the title
botanegg
reviewed
Oct 28, 2022
kevinpollet
force-pushed
the
feat/4202
branch
from
2f90593
to
b44f02f
Compare
tomMoulard
force-pushed
the
feat/4202
branch
from
2929787
to
6fd41fe
Compare
mpl
reviewed
Nov 15, 2022
kevinpollet
reviewed
Nov 15, 2022
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
mpl
approved these changes
Nov 15, 2022
|
Thank you so much! |
|
Thank you! |
|
Can someone help as to how can I turn on brotli (possibly within docker-compose config)? Powered up v 2.9.5 in docker image but not sure how to go about replacing gzip with brotli compression? |
|
Hello @martinbabic, The milestone of this PR is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hackaethon (Hackathon) entry
What does this PR do?
This PR adds support for the Brotli compression algorithm to Traefik.
Some breaking changes:
a new functionality is that if a request's
Accept-Encodingheader is set to*, a compressed response will now be sent, instead of the previous non-compressed response. Brotli is used when*is set because the gzip library used seems to ignore it.Also, If the Accept-Encoding request header is absent, it is meant as br compression is requested. If it is present, but its value is the empty string, then compression is disabled.
Fixes #4202
Motivation
This was a suggested issue for the Traefik Proxy 3.0 Hackaethon. It looked achievable with my schedule.
More
Additional Notes
Co-authored-by: Mathieu Lonjaret mathieu.lonjaret@gmail.com
Co-authored-by: Tom Moulard tom.moulard@traefik.io
Co-authored-by: Romain rtribotte@users.noreply.github.com
Co-authored-by: Kevin Pollet pollet.kevin@gmail.com