Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HTTPRequestRedirectFilter in k8s Gateway API #9408

Merged
merged 10 commits into from
Dec 22, 2022
Merged

Add support for HTTPRequestRedirectFilter in k8s Gateway API #9408

merged 10 commits into from
Dec 22, 2022

Conversation

romantomjak
Copy link
Contributor

@romantomjak romantomjak commented Oct 2, 2022 •
edited
Loading

What does this PR do?

Adds HTTPRequestRedirectFilter support to k8s Gateway API provider

Motivation

See discussion in #8705

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@romantomjak romantomjak mentioned this pull request Oct 2, 2022
Open
2 tasks
rtribotte
rtribotte reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

pkg/provider/kubernetes/gateway/kubernetes.go Outdated Show resolved Hide resolved
@kevinpollet kevinpollet changed the title add support for HTTPRouteFilter's in k8s Gateway API Add support for HTTPRouteFilter's in k8s Gateway API Oct 3, 2022
@romantomjak romantomjak changed the title Add support for HTTPRouteFilter's in k8s Gateway API Add support for HTTPRequestRedirectFilter in k8s Gateway API Oct 5, 2022
@romantomjak romantomjak marked this pull request as ready for review October 5, 2022 19:54
@kevinpollet kevinpollet added this to To review in v2 via automation Oct 6, 2022
@romantomjak romantomjak mentioned this pull request Oct 26, 2022
Open
2 tasks
rtribotte
rtribotte approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

tomMoulard
tomMoulard approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@rtribotte rtribotte added this to the 3.0 milestone Dec 21, 2022
@rtribotte rtribotte changed the base branch from master to v3.0 December 21, 2022 13:35
nmengin
nmengin approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@traefiker traefiker merged commit d046af2 into traefik:v3.0 Dec 22, 2022
v2 automation moved this from To review to Done Dec 22, 2022
@romantomjak romantomjak deleted the gatewayapi-redirect branch July 18, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@tomMoulard tomMoulard tomMoulard approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/gatewayapi kind/enhancement a new or improved feature. size/L
Projects
No open projects
v2
Done
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@romantomjak @nmengin @tomMoulard @rtribotte @kevinpollet @traefiker