-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming IPWhiteList to IPAllowList #9457
Conversation
Hello @Wambug and thanks for your contribution, After a quick review, we saw that you missed renaming the Please, could you also ensure that the case is always the same as before? |
sure lemme make the corrections👍 |
Thanks for updating the pull request, but you did not actually fix the case (e.g. https://github.com/traefik/traefik/pull/9457/files#diff-60c4d1d064d90b88b5a75e66f98620429a4a685cf91054164c96cb609d138b93R2 Please, could you update the pull request? |
ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
anytime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
may i ask why this was done? what new functionality does allowlist provide over whitelist? |
Hello @mrambossek, This is not expected, as you can see #10341 reintroduced the |
unfortunately, i was not able to reconstruct this on the affected systems yet because .. well, they are in production :) |
What does this PR do?
Renaming IpWhiteList to IpAllowList.
Motivation
Fixes #9437
More
Additional Notes