-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TCP Servers Transports support #9465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
a new or improved feature.
area/tcp
and removed
area/provider/docker
area/provider/consul
area/provider/marathon
area/provider/rancher
area/provider/ecs
area/provider/k8s/crd
area/provider/k8s
labels
Oct 24, 2022
sdelicata
force-pushed
the
tcp_servers_transport
branch
from
October 24, 2022 15:54
ba096bc
to
1359908
Compare
sdelicata
force-pushed
the
tcp_servers_transport
branch
from
November 21, 2022 08:41
1359908
to
9b00236
Compare
tomMoulard
force-pushed
the
tcp_servers_transport
branch
3 times, most recently
from
November 24, 2022 16:06
d4ff6fd
to
66e44a0
Compare
tomMoulard
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
rtribotte
force-pushed
the
tcp_servers_transport
branch
from
November 30, 2022 15:43
66e44a0
to
d685f0e
Compare
… every conf update
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
rtribotte
force-pushed
the
tcp_servers_transport
branch
from
December 9, 2022 08:13
088cdb4
to
4afbc1e
Compare
rtribotte
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces TCP servers transports support.
Motivation
Fixes #7803
More
Additional Notes
Co-authored-by: Antoine Couchard couchardantoine@gmail.com
Co-authored-by: Romain rtribotte@users.noreply.github.com