Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redirect regex #947

Merged
merged 1 commit into from Dec 9, 2016
Merged

Fix redirect regex #947

merged 1 commit into from Dec 9, 2016

Conversation

emilevauge
Copy link
Member

@emilevauge emilevauge commented Dec 8, 2016 •
edited

This PR fixes redirect regex with domains containing _.

Fixes #952

Signed-off-by: Emile Vauge emile@vauge.com

@emilevauge
Fix redirect regex
8156082 
Signed-off-by: Emile Vauge <emile@vauge.com>
@emilevauge emilevauge added this to the 1.1 milestone Dec 8, 2016
vdemeester
vdemeester approved these changes Dec 8, 2016
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐻

@emilevauge emilevauge merged commit 70f39c3 into v1.1 Dec 9, 2016
@emilevauge emilevauge mentioned this pull request Dec 14, 2016
Closed
@emilevauge emilevauge deleted the fix-redirect-regex branch April 4, 2017 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilevauge @vdemeester