Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HostSNIRegexp in GatewayAPI TLS routes #9486

Merged
merged 2 commits into from Dec 12, 2022
Merged

Support HostSNIRegexp in GatewayAPI TLS routes #9486

merged 2 commits into from Dec 12, 2022

Conversation

ddtmachado
Copy link
Contributor

@ddtmachado ddtmachado commented Oct 31, 2022 •
edited

What does this PR do?

Adds support for HostSNIRegexp to TLS routes in the Gateway API provider

Motivation

Fixes #8861

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@kevinpollet kevinpollet added this to To review in v2 via automation Nov 2, 2022
@ddtmachado ddtmachado changed the title Support HostSNI and HostSNIRegexp in GatewayAPI TCP routes Support HostSNIRegexp in GatewayAPI TLS routes Nov 9, 2022
@rtribotte rtribotte changed the base branch from master to v3.0 December 12, 2022 08:48
@tomMoulard tomMoulard force-pushed the gtw-tcphostname branch 2 times, most recently from f145af0 to 38bf814 Compare December 12, 2022 15:08
tomMoulard
tomMoulard approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

rtribotte
rtribotte approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

ldez
ldez approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added this to the 3.0 milestone Dec 12, 2022
@traefiker traefiker merged commit a08a428 into traefik:v3.0 Dec 12, 2022
v2 automation moved this from To review to Done Dec 12, 2022
@tomMoulard tomMoulard mentioned this pull request Jan 10, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@tomMoulard tomMoulard tomMoulard approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/gatewayapi area/provider/k8s kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
3.0
6 participants
@ddtmachado @ldez @tomMoulard @rtribotte @kevinpollet @traefiker