Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New logger for the Traefik logs #9515

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Nov 18, 2022

What does this PR do?

Replace logrus by zerolog.

New console format.
Improvements of the log fields.

Drops USR1 signal to rotate the logs.
The rotation is handled by Traefik itself.

Performance improvements.

This PR is only about Traefik logs and not access logs, the access logs will be handled in another PR.

Motivation

Related to #9453

Fixes #8529
Fixes #3489

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

update oxy to v2

@ldez ldez added this to the next milestone Nov 18, 2022
@ldez ldez added this to To review in v2 via automation Nov 18, 2022
@ldez ldez force-pushed the feat/new-logger branch 6 times, most recently from d1dcd3f to b8e6950 Compare November 19, 2022 12:31
pkg/logs/oxy.go Show resolved Hide resolved
pkg/logs/haystack.go Show resolved Hide resolved
pkg/logs/instana.go Show resolved Hide resolved
pkg/logs/jaeger.go Show resolved Hide resolved
@ldez ldez force-pushed the feat/new-logger branch 5 times, most recently from 2e9bf92 to 0272083 Compare November 21, 2022 09:21
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@traefiker traefiker merged commit 56f7515 into traefik:master Nov 21, 2022
v2 automation moved this from To review to Done Nov 21, 2022
@ldez ldez deleted the feat/new-logger branch November 21, 2022 18:49
@ldez ldez linked an issue Nov 21, 2022 that may be closed by this pull request
2 tasks
@devstudio-release

This comment was marked as spam.

@devstudio-release

This comment was marked as spam.

@devstudio-release

This comment was marked as spam.

@devstudio-release

This comment was marked as spam.

@devstudio-release

This comment was marked as spam.

@devstudio-release

This comment was marked as spam.

@devstudio-release

This comment was marked as spam.

@devstudio-release

This comment was marked as spam.

@devstudio-release

This comment was marked as spam.

@hengdai
Copy link

hengdai commented Apr 20, 2023

Hope accesslog logger replace by zerolog soon, becouse logrus is very low performance than zerolog.
thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants