Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated options #9527

Merged
merged 9 commits into from
Nov 25, 2022
Merged

Conversation

sdelicata
Copy link
Contributor

@sdelicata sdelicata commented Nov 22, 2022

What does this PR do?

This PR removes:

  • the pilot option from the static configuration
  • the tracing.datadog.globaltag option
  • the namespace option of Consul, Consul Catalog, and Nomad providers
  • the tls.caOptional option from the ForwardAuth middleware, as well as from the HTTP, Consul, Etcd, Redis, ZooKeeper, Marathon, Consul Catalog, and Docker providers
  • sslRedirect, sslTemporaryRedirect, sslHost, sslForceHost, and featurePolicy options of the Headers middleware
  • the forceSlash option of the StripPrefix middleware
  • the preferServerCipherSuites option

Motivation

Remove deprecated options that were supposed to be removed on v3.

More

  • Added/updated tests
  • Added/updated documentation

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdelicata sdelicata requested review from ldez and removed request for tomMoulard November 24, 2022 09:06
Copy link
Member

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@ldez ldez added the breaking label Nov 25, 2022
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking kind/enhancement a new or improved feature. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants