Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change traefik cmd error log to error level #9569

Merged

Conversation

tomMoulard
Copy link
Member

What does this PR do?

Set up the right log level on Traefik cmd error.

Motivation

Show errors when launching traefik in logs other than DEBUG.

More

  • [ ] Added/updated tests
  • [ ] Added/updated documentation

Additional Notes

before/after comparison

before:

2022-12-01T14:00:00+00:00 DBG ../../../../../.local/opt/go1.19.3/src/log/log.go:198 > 2022/12/01 14:00:00 traefik.go:84: command traefik error: error while building entryPoint http: error preparing server: error opening listener: listen tcp :80: bind: permission denied

after:

2022-12-01T14:00:00+00:00 ERR cmd/traefik/traefik.go:83 > Command error error="command traefik error: error while building entryPoint http: error preparing server: error opening listener: listen tcp :80: bind: permission denied"

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix/update-traefik-cmd-log-level branch from 37c63ab to 4371ad7 Compare December 7, 2022 10:10
@traefiker traefiker merged commit 6c75052 into traefik:master Dec 7, 2022
@tomMoulard tomMoulard deleted the fix/update-traefik-cmd-log-level branch December 7, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants