Sanitize X-Forwarded-Proto header in RedirectScheme middleware #9598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a typo in the commit message title |
ldez
changed the title
|
Is it intended that this would also cause a redirect for an invalid X-Forwarded-Proto header (like a combination of two of them, |
|
Yes, it's intended because by convention this header is mono-valued. |
rtribotte
reviewed
Dec 13, 2022
ldez
force-pushed
the
fix/redirect-xForwardedProto
branch
from
d858115
to
6633b12
Compare
tomMoulard
approved these changes
Dec 16, 2022
2 tasks
rtribotte
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sanitize X-Forwarded-Proto header in RedirectScheme middleware
Motivation
Fixes #9597
More
Added/updated documentationAdditional Notes
Co-authored-by: Julien Salleyron julien.salleyron@gmail.com