Prevent from no rate limiting when average is zero #9621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We had already noted that we were relying on a buggy behaviour of x/time, and we had opened an issue for that: |
|
I wasn't aware of this issue was already submitted and I don't have any idea if this was fixed. My PR findings were discovered because of the docs vs code difference and the PR fix an issue with the following scenario. |
mpl
force-pushed
the
fix-disabling-ratelimiter
branch
2 times, most recently
from
699ac18
to
bf1ecfb
Compare
mpl
force-pushed
the
fix-disabling-ratelimiter
branch
from
bf1ecfb
to
f354947
Compare
mpl
added
status/2-needs-review
kind/bug/fix
mpl
approved these changes
Jan 3, 2023
mpl
force-pushed
the
fix-disabling-ratelimiter
branch
from
4201925
to
de25cde
Compare
rtribotte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Docs about
ratelimitsays that you can omit rate limiting by specifyingaverageas0. In traefik version< 2.7.2it was true version2.7.2introduce a bug and you cannot disable rate limiting in that way. The bug was probably related to bumping package golang.org/x/time. This change treats zero limits differently and nowrate.Infshould be set whenaverage == 0.Motivation
To restore the option with disabling rate limiting, which broke when the bug we relied on got fixed in x/time/rate:
https://go-review.googlesource.com/c/time/+/323429
More
Additional Notes