Fix open connections metric #9656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpl
added
area/middleware/metrics
kind/bug/fix
ldez
approved these changes
Mar 20, 2023
mmatur
added
bot/no-merge
status/3-needs-merge
and removed
status/3-needs-merge
status/4-merge-in-progress
bot/merge-retry-1
bot/no-merge
labels
traefiker
added
bot/need-human-merge
and removed
bot/merge-retry-1
status/4-merge-in-progress
labels
mmatur
force-pushed
the
fix-open-connections-metric
branch
from
5db495b
to
d35899f
Compare
This was referenced May 4, 2024
Closed
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the (broken) "Open connections" metric from the entryPoint, router, and service, and replaces them with a new (correct) metric at the server/global level.
As a notable side-effect, this is now the first metric that can be considered a TCP metric.
Motivation
The previous metric Open connections was incorrect as it was computed. It was done at the ServeHTTP level, and was therefore basically computing the number of inflight requests instead of the number of connections.
This PR therefore fixes the implementation so that it matches the intended meaning, and computes the metric at the TCP level, where/when the connections are opened and closed.
Consequently, it does not make any sense to keep labels related to the application/HTTP layer, such as the protocol (as it was before) and the method. There is still a protocol label, but its meaning will now be to differentiate the transport (TCP VS UDP).
More
Additional Notes
Addresses #7575
Fixes #4226
Co-authored-by: Romain rtribotte@users.noreply.github.com