New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add note about remoteaddr strategy #9701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello - just wanted to let you know that you might also want to make the same note in InFlightReq and RateLimit middlewares (where the same ipStrategy + XFF confusion can arise) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 📚
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
What does this PR do?
this PR adds a couple of notes about the default ipstrategy, and about the lifecycle of X-Forwarded-For.
Motivation
Users were not aware of the default remoteaddr ipstrategy.
More
- [ ] Added/updated testsAdditional Notes
Fixes #9696