Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DeepCopy of PluginConf #9846

Merged
merged 1 commit into from Apr 17, 2023
Merged

Improve DeepCopy of PluginConf #9846

merged 1 commit into from Apr 17, 2023

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 17, 2023

What does this PR do?

Use DeepCopy when available with the content of PluginConf.

Motivation

Better DeepCopy

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Apr 17, 2023
@traefiker traefiker added this to the 2.10 milestone Apr 17, 2023
juliens
juliens approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the fix/plugin-conf-deepcopy branch 3 times, most recently from 214dbfd to 2dd107e Compare April 17, 2023 13:39
rtribotte
rtribotte approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@traefiker traefiker merged commit 5635687 into traefik:v2.10 Apr 17, 2023
9 checks passed
v2 automation moved this from To review to Done Apr 17, 2023
@ldez ldez deleted the fix/plugin-conf-deepcopy branch April 17, 2023 15:34
@rtribotte rtribotte changed the title fix: DeepCopy of PluginConf Improve DeepCopy of PluginConf Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@rtribotte rtribotte rtribotte approved these changes

Assignees
No one assigned
Labels
area/plugins kind/bug/fix a bug fix size/M
Projects
No open projects
v2
Done
Milestone
2.10
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @rtribotte @traefiker