Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-acme/lego to v4.12.0 #9918

Merged
merged 1 commit into from May 29, 2023
Merged

Update go-acme/lego to v4.12.0 #9918

merged 1 commit into from May 29, 2023

Conversation

ldez
Copy link
Member

@ldez ldez commented May 28, 2023 •
edited

What does this PR do?

Update go-acme/lego to v4.12.0

go-acme/lego@v4.11.0...v4.12.0

Motivation

Fixes:

  • [dnsprovider] autodns: fixes wrong zone in api call if CNAME is used

More

  • [ ] Added/updated tests
  • Added/updated documentation

Additional Notes

  • [dnsprovider] Refactor DNS provider and client implementations
  • [dnsprovider] route53: pass ExternalID property to STS:AssumeRole API operation
  • [dnsprovider] Add DNS provider for Derak Cloud

@ldez ldez added status/2-needs-review area/acme kind/bug/fix a bug fix bot/light-review decreases the number of required LGTM from 3 to 1. labels May 28, 2023
@ldez ldez added this to the 2.10 milestone May 28, 2023
@ldez ldez added this to To review in v2 via automation May 28, 2023
tomMoulard
tomMoulard reviewed May 29, 2023
View reviewed changes
Copy link
Member

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

tomMoulard
tomMoulard approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@traefiker traefiker merged commit 8d8717d into traefik:v2.10 May 29, 2023
9 checks passed
v2 automation moved this from To review to Done May 29, 2023
@traefiker traefiker removed status/3-needs-merge bot/light-review decreases the number of required LGTM from 3 to 1. labels May 29, 2023
@ldez ldez deleted the fix/update-lego branch May 29, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomMoulard tomMoulard tomMoulard approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldez @tomMoulard @traefiker