Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages related to plugins #9924

Merged
merged 3 commits into from Jun 2, 2023

Conversation

ldez
Copy link
Member

@ldez ldez commented May 30, 2023

What does this PR do?

Add more contextual information to some errors related to plugins.

Motivation

Fixes #9911

More

  • [ ] Added/updated tests
  • [ ] Added/updated documentation

@ldez ldez added this to To review in v2 via automation May 30, 2023
@traefiker traefiker added this to the 2.10 milestone May 30, 2023
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

cmd/traefik/plugins.go Outdated Show resolved Hide resolved
cmd/traefik/plugins.go Outdated Show resolved Hide resolved
pkg/plugins/client.go Outdated Show resolved Hide resolved
pkg/plugins/client.go Outdated Show resolved Hide resolved
pkg/plugins/client.go Outdated Show resolved Hide resolved
pkg/plugins/client.go Outdated Show resolved Hide resolved
pkg/plugins/client.go Outdated Show resolved Hide resolved
pkg/plugins/client.go Outdated Show resolved Hide resolved
pkg/plugins/client.go Outdated Show resolved Hide resolved
pkg/plugins/client.go Outdated Show resolved Hide resolved
@traefiker traefiker merged commit 9aa57f3 into traefik:v2.10 Jun 2, 2023
9 checks passed
v2 automation moved this from To review to Done Jun 2, 2023
@traefiker traefiker mentioned this pull request Jun 2, 2023
2 tasks
@ldez ldez deleted the fix/improve-error-plugins branch June 2, 2023 09:34
@ldez ldez changed the title fix: improve error messages related to plugins Improve error messages related to plugins Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants