Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(limited) support for building w/ master #928

Closed
sbinet opened this issue Oct 26, 2020 · 1 comment · Fixed by #943
Closed

(limited) support for building w/ master #928

sbinet opened this issue Oct 26, 2020 · 1 comment · Fixed by #943
Assignees
Labels
area/extract wrapper generation area/stdlib enhancement New feature or request
Milestone

Comments

@sbinet
Copy link
Contributor

sbinet commented Oct 26, 2020

Proposal

it would be great if one could build yægi using the Go gc compiler's next version.
right now, when using the compiler from master, ad compiling yægi, one gets:

$> go get -v ./...
package github.com/traefik/yaegi/cmd/yaegi
	imports github.com/traefik/yaegi/stdlib/syscall: build constraints exclude all Go files in /home/binet/work/gonum/src/github.com/containous/yaegi/stdlib/syscall
package github.com/traefik/yaegi/cmd/yaegi
	imports github.com/traefik/yaegi/stdlib/unsafe: build constraints exclude all Go files in /home/binet/work/gonum/src/github.com/containous/yaegi/stdlib/unsafe

the standard library doesn't insert that many new symbols from one release cycle to the next, so it seems to me it would be relatively cheap to just add the build constraints for n+1 whenever the Go release n is cut.

added benefit: earlier bug reports w/ the next Go release that yægi will have to support.

@mvertes
Copy link
Member

mvertes commented Nov 5, 2020

With #943, the build tag on next Go version will be not added to wrappers, allowing to build yaegi using a Go devel version with support of stdlib. Note that go generate must not be run, as symbol extraction will fail with non stable Go versions.

@traefiker traefiker added this to the v0.9.x milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extract wrapper generation area/stdlib enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants