Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interp: improve handling of generic types #1489

Merged
merged 14 commits into from Feb 8, 2023
Merged

interp: improve handling of generic types #1489

merged 14 commits into from Feb 8, 2023

Commits on Feb 3, 2023

  1. interp: improve handling of generic types 

    When generating a new type, the parameter type was not correctly
duplicated in the new AST. This is fixed by making copyNode recursive
if needed. The out of order processing of generic types has also been
fixed.

Fixes traefik#1488.
    @mvertes @ldez
    mvertes authored and ldez committed Feb 3, 2023
    Copy the full SHA
    4b05873 View commit details
    Browse the repository at this point in the history

  2. Handle the case where a generic type is instantiated before method 

    declaration, which was leading to missing methods in the generated
type.
    @mvertes @ldez
    mvertes authored and ldez committed Feb 3, 2023
    Copy the full SHA
    ee89ec0 View commit details
    Browse the repository at this point in the history

  3. add test with method declared after generic instanciation

    @mvertes @ldez
    mvertes authored and ldez committed Feb 3, 2023
    Copy the full SHA
    17b1885 View commit details
    Browse the repository at this point in the history

  4. additional fixes for more complex use cases

    @mvertes @ldez
    mvertes authored and ldez committed Feb 3, 2023
    Copy the full SHA
    c6f9527 View commit details
    Browse the repository at this point in the history

  5. lint

    @mvertes @ldez
    mvertes authored and ldez committed Feb 3, 2023
    Copy the full SHA
    d381f0f View commit details
    Browse the repository at this point in the history

  6. Several fixes to handle call of recursive type infered generics

    @mvertes @ldez
    mvertes authored and ldez committed Feb 3, 2023
    Copy the full SHA
    22f0e88 View commit details
    Browse the repository at this point in the history

  7. passing types instead of nodes when generating AST for generics. WIP.

    @mvertes @ldez
    mvertes authored and ldez committed Feb 3, 2023
    Copy the full SHA
    e5219b0 View commit details
    Browse the repository at this point in the history

  8. add missing substitution of generic type by instance

    @mvertes @ldez
    mvertes authored and ldez committed Feb 3, 2023
    Copy the full SHA
    a71ac85 View commit details
    Browse the repository at this point in the history

  9. add test for previous

    @mvertes @ldez
    mvertes authored and ldez committed Feb 3, 2023
    Copy the full SHA
    30c5653 View commit details
    Browse the repository at this point in the history

  10. fix lint, fix generic methods with multiple type parameters

    @mvertes @ldez
    mvertes authored and ldez committed Feb 3, 2023
    Copy the full SHA
    631dfa8 View commit details
    Browse the repository at this point in the history

  11. Support generic type in composite literal expression

    @mvertes @ldez
    mvertes authored and ldez committed Feb 3, 2023
    Copy the full SHA
    1914c33 View commit details
    Browse the repository at this point in the history

  12. lint

    @mvertes @ldez
    mvertes authored and ldez committed Feb 3, 2023
    Copy the full SHA
    b153bb4 View commit details
    Browse the repository at this point in the history

  13. lint

    @mvertes @ldez
    mvertes authored and ldez committed Feb 3, 2023
    Copy the full SHA
    a192ae3 View commit details
    Browse the repository at this point in the history

  14. fix generic instance name, revert previous fix attempt of the same issue

    @mvertes @ldez
    mvertes authored and ldez committed Feb 3, 2023
    Copy the full SHA
    8c5a398 View commit details
    Browse the repository at this point in the history