Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detect default comm clause in select from AST #678

Merged
merged 3 commits into from
Jun 10, 2020
Merged

fix: detect default comm clause in select from AST #678

merged 3 commits into from
Jun 10, 2020

Conversation

mvertes
Copy link
Member

@mvertes mvertes commented Jun 4, 2020

The heuristic to distinguish a default comm clause was too weak.
Make it robust by using AST.

Fixes #646.

@mvertes
fix: detect default comm clause in select from AST
d5d922a 
The heuristic to distinguish a default comm clause was too weak.
Make it robust by using AST.

Fixes #646.
@mvertes mvertes added bug Something isn't working area/core labels Jun 4, 2020
@mvertes mvertes added this to the v0.8.x milestone Jun 4, 2020
@mvertes mvertes requested a review from nrwiersma June 4, 2020 08:26
@mvertes mvertes merged commit 82b499a into master Jun 10, 2020
@mvertes mvertes deleted the fix-646 branch June 10, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrwiersma nrwiersma nrwiersma approved these changes

Assignees
No one assigned
Labels
area/core bug Something isn't working
Projects
None yet
Milestone
v0.13.x
Development

Successfully merging this pull request may close these issues.

not able to cast in the select default
2 participants
@mvertes @nrwiersma