Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return correct package name for parsed package #679

Merged
merged 2 commits into from
Jun 10, 2020
Merged

fix: return correct package name for parsed package #679

merged 2 commits into from
Jun 10, 2020

Conversation

nrwiersma
Copy link
Contributor

When importing an already imported package, the package name should not be empty. At this point we only have the path, so we need to keep track of the path -> pkgName to return the correct one.

@mvertes mvertes added area/core bug Something isn't working labels Jun 4, 2020
@mvertes mvertes added this to the v0.8.x milestone Jun 4, 2020
@nrwiersma nrwiersma requested a review from mvertes June 5, 2020 06:38
Copy link
Member

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mvertes mvertes merged commit 36836cd into traefik:master Jun 10, 2020
@nrwiersma nrwiersma deleted the fix-parsed-pkgname branch June 10, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants