Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: composite map assign #683

Merged
merged 3 commits into from
Jun 10, 2020
Merged

fix: composite map assign #683

merged 3 commits into from
Jun 10, 2020

Conversation

nrwiersma
Copy link
Contributor

When doing a composite map assign, the assign was optimised out, and so is the map index, leaving just a composite, which never sets the value in the map. The assign cannot be optimised out in this case.

Fixes #680

@nrwiersma nrwiersma requested a review from mvertes June 5, 2020 06:38
@mvertes mvertes added area/core bug Something isn't working labels Jun 10, 2020
@mvertes mvertes added this to the v0.8.x milestone Jun 10, 2020
mvertes
mvertes approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mvertes mvertes merged commit 8365f68 into traefik:master Jun 10, 2020
@nrwiersma nrwiersma deleted the composite-map-assign branch June 10, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvertes mvertes mvertes approved these changes

Assignees
No one assigned
Labels
area/core bug Something isn't working
Projects
None yet
Milestone
v0.13.x
Development

Successfully merging this pull request may close these issues.

Map not adding a composite literal
2 participants
@nrwiersma @mvertes