Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assert switch type from valueT in struct case #747

Merged
merged 2 commits into from Jul 6, 2020

Conversation

nrwiersma
Copy link
Contributor

In a struct case in type assertion, if the source is a valueT, we still need to take the struct type to allow method and field resolution.

Fixes #746

@nrwiersma nrwiersma added bug Something isn't working area/core labels Jul 6, 2020
@nrwiersma nrwiersma added this to the v0.8.x milestone Jul 6, 2020
@nrwiersma nrwiersma requested a review from mvertes July 6, 2020 10:13
@nrwiersma nrwiersma self-assigned this Jul 6, 2020
In a struct case in type assertion, if the source is a valueT, we still need to take the struct type to allow method and field resolution.
Copy link
Member

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvertes mvertes merged commit 8514444 into traefik:master Jul 6, 2020
@nrwiersma nrwiersma deleted the fix-746 branch July 6, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type assertion with struct on valueT not working properly
2 participants