Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle interfaces in composite sparse #749

Merged
merged 3 commits into from Jul 6, 2020
Merged

fix: handle interfaces in composite sparse #749

merged 3 commits into from Jul 6, 2020

Conversation

nrwiersma
Copy link
Contributor

Due to the assignment optimisation for composite sparse, assigning to an interface must be handled in doCompositeSparse.

Fixes #748

@nrwiersma nrwiersma added bug Something isn't working area/core labels Jul 6, 2020
@nrwiersma nrwiersma added this to the v0.8.x milestone Jul 6, 2020
@nrwiersma nrwiersma requested a review from mvertes July 6, 2020 11:40
@nrwiersma nrwiersma self-assigned this Jul 6, 2020
mvertes
mvertes approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvertes mvertes merged commit 9d4685d into traefik:master Jul 6, 2020
@nrwiersma nrwiersma deleted the fix-748 branch July 6, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvertes mvertes mvertes approved these changes

Assignees

@nrwiersma nrwiersma

Labels
area/core bug Something isn't working
Projects
None yet
Milestone
v0.13.x
Development

Successfully merging this pull request may close these issues.

cannot create and assign struct to interface
2 participants
@nrwiersma @mvertes