This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Improved error handling, run delete/find tests in CI #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
force-pushed
the
fix/error-handling
branch
from
7cf78eb
to
b0f41ae
Compare
traeok
changed the title
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
force-pushed
the
fix/error-handling
branch
from
b0f41ae
to
3c1c9f2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Probably should be tested on a macOS machine to confirm no breaking changes - but, code does cross-compile w/o errors, and core functionality remains the same.Update: Thanks @awharn for testing this on macOS for x86_64 and aarch64 😄
Previously, the core implementation was using an Error struct. This has been changed to an enum and avoids extra boilerplate for error formatting, thanks to the
thiserrorcrate.This PR also adds the test functions for
deletePassword, findCredentials, & findPasswordunder the following Yarn scripts:test:deletetest:findTests are still set-up to only run get/set with
yarn test- CI was updated to run those above scripts in succession.