The opencv build, when the env var CARGO_FEATURE_GEN_FEATS is set, wi… #4
Conversation
ereichert
force-pushed
the
feature/build_script
branch
6 times, most recently
from
c8d1f15
to
4e182b2
Compare
…ll update the features listed in the Cargo.toml file. It derives the list of features from the CMakeLists.txt file in the downloaded source code. This commit also includes changes to minimize required work when building and generating features.
ereichert
force-pushed
the
feature/build_script
branch
from
4e182b2
to
1bda93b
Compare
|
@ryandbair I think this is done. The command line I used for testing is:
|
|
I'm not able to get the PNGs to build, both with the command above as well as compiling with tlx2 and the with_png_on flag set. |
|
I should have used build_png_on, that works fine. |
|
I used with_png_on and that's specified in the TLX 2 build now as well. But looking at it further, I'm now sure if with_png_on should work on its own. Thing is I've built TLX 2 multiple times without an issue. So I'm not really sure what's going on with that. |
That comment isn't showing up on the PR, but featureA = ["build"] means that featureA depends on the build feature. I think that's so you can specify featureA in a consumer and not have to specify build. |
|
I'm getting this failure on TLX2 (it builds fine by itself):
The file actually exists at: |
|
try adding build_png_on and with_png_on to the TLX 2 features. And do a clean. |
|
Same deal with both features enabled. liblibpng.a exists, so I know its build built at least. Either the build isn't moving it to the right place or the script is expecting it to be in the wrong place. When you build, where does liblibpng.a end up? |
|
I cargo cleaned both TLX 2 and opencv. Built opencv-rust using the command above and TLX 2 with the features specified in the PR for TLX 2. No problems. So there's something different about our configs that's causing an issue. |
|
build_shared_libs_off and build_png_on was required to build on tlx2 |
…ll update the features listed in the Cargo.toml file. It derives the list of features from the CMakeLists.txt file in the downloaded source code. This commit also includes changes to minimize required work when building and generating features.