Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search plugin #15

Closed
wants to merge 1 commit into from
Closed

Add search plugin #15

wants to merge 1 commit into from

Conversation

byzheng
Copy link
Contributor

@byzheng byzheng commented Nov 17, 2016

No description provided.

@bhaskarvk
Copy link
Contributor

I haven't forgotten this, I'll merge this next week.

@bhaskarvk
Copy link
Contributor

Thanks, I've merged this in trunk. I couldn't do straight up merging, but had to cherrypick your commit. I also upgraded the plugin to the latest version and added more options.

Thanks again for your contribution.

@bhaskarvk bhaskarvk closed this Nov 30, 2016
@bhaskarvk bhaskarvk self-assigned this Nov 30, 2016
@bhaskarvk bhaskarvk added this to the Milestone 2 milestone Nov 30, 2016
@NahuelGrasso
Copy link

Hello,
first of all, this is a great functionality!
I wonder if it's possible to search for markers than belong to a mix of groups. For instance, markers that belong to group 'churches' and group 'casinos'.
I tried this:
addSearchMarker(
targetGroup = c('churches','casinos'),...)
but didn't work. Any suggestions? adding other "addSearchMarker" didn't work either.
Thanks in advance.
Nahuel

@bhaskarvk
Copy link
Contributor

@NahuelGrasso Currently not, but it might be possible for me to provide a way to do such a thing. I'll create a new issue to track this.

@bhaskarvk bhaskarvk mentioned this pull request Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants