Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cylinder-shaped nodes #145

Closed
6 tasks done
SOF3 opened this issue Jul 22, 2021 · 1 comment
Closed
6 tasks done

Support cylinder-shaped nodes #145

SOF3 opened this issue Jul 22, 2021 · 1 comment
Labels
G: Feature New features that change user experience

Comments

@SOF3
Copy link
Member

SOF3 commented Jul 22, 2021

  • Implement shape::Unit::contains
  • Implement shape::Unit::between for Cylinder #151
  • Implement shape::Unit::bb_under
  • Adapt cylinder position/normal buffer for node rendering
  • Add cylinder texture type
    • curve.svg: f(x, y) = (cos 2x pi, sin 2x pi, y)
    • top.svg and bottom.svg: f(x, y) = (x, y, 0 or 1), area beyond unit circle unused
  • Check other places hardcoded with shape::Cube
@SOF3 SOF3 added the G: Feature New features that change user experience label Jul 22, 2021
@SOF3
Copy link
Member Author

SOF3 commented Jul 24, 2021

Currently all shapes use DUMMY_CUBE_SPRITES as the dummy sprite set when the texture is loading. Although inconsistent, this does not appear to be problematic since cube is the shape with the most sprites (6) compared to cylinder (3) and sphere (1).

@SOF3 SOF3 closed this as completed Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
G: Feature New features that change user experience
Projects
None yet
Development

No branches or pull requests

1 participant