Properly check for key presence #465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hashes can have default values different from nil, see https://docs.ruby-lang.org/en/2.5.0/Hash.html#method-i-default-3D So we must not rely on the hash returning nil for missing keys.
|
But if the value is nil, then Collection.new will crash since nil don't have |
|
That is correct, but why would the user explicitly set the collection to nil? How does this differ from setting the collection to true or the number 3, which we don't protect against either? The usual contract of a collection with no items is, well, an empty collection. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hashes can have default values different from
nil, see https://docs.ruby-lang.org/en/2.5.0/Hash.html#method-i-default-3DSo we must not rely on the hash returning
nilfor missing keys.