make the FakeServer properly parse incoming documents so the HttpVerb…

…sTest becomes a real test that actually finds bugs (thanks @nleguen for spotting!).
trailblazer · Jun 22, 2012 · 127dba9 · 127dba9
1 parent 6bfe80d
commit 127dba9
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 16 deletions.
diff --git a/test/fake_server.rb b/test/fake_server.rb
@@ -1,10 +1,34 @@
 require "bundler/setup"
-require 'sinatra/base'
+require "sinatra/base"
+require "roar/representer/json"
 
 class FakeServer < Sinatra::Base
-
   set :raise_errors, false
 
+  module BandRepresenter
+    include Roar::Representer::JSON
+
+    property :name
+    property :label
+  end
+
+  class Band
+    attr_reader :name, :label
+
+    def name=(value)
+      @name = value.upcase
+    end
+
+    def label=(value)
+      @label = value.upcase
+    end
+  end
+
+  def consume_band
+    Band.new.extend(BandRepresenter).from_json(request.body.string)
+  end
+
+
   get "/method" do
     "<method>get</method>"
   end
@@ -31,19 +55,20 @@ class FakeServer < Sinatra::Base
 
   post "/bands" do
     #if request.content_type =~ /xml/
-    body  '{"label": "n/a", "name": "Strung Out", "links": [{"href":"http://search", "rel": "search"}, {"href":"http://band/strungout", "rel": "self"}]}'
+    body consume_band.to_json
+
     status 201
   end
 
   put "/bands/strungout" do
     # DISCUSS: as long as we don't agree on what to return in PUT/PATCH, let's return an updated document.
-    {:name => "Strung Out", :label => "Fat Wreck"}.to_json
+    body consume_band.to_json
     #status 204
   end
 
   patch '/bands/strungout' do
     # DISCUSS: as long as we don't agree on what to return in PUT/PATCH, let's return an updated document.
-    {:name => 'Strung Out', :label => 'Fat Mike'}.to_json
+    body consume_band.to_json
     #status 204
   end
 

diff --git a/test/http_verbs_feature_test.rb b/test/http_verbs_feature_test.rb
@@ -3,12 +3,7 @@
 require 'roar/representer/json'
 
 class HttpVerbsTest < MiniTest::Spec
-  module BandRepresenter
-    include Roar::Representer::JSON
-
-    property :name
-    property :label
-  end
+  BandRepresenter = FakeServer::BandRepresenter
 
   # keep this class clear of Roar modules.
   class Band
@@ -80,8 +75,8 @@ class Band
         assert_equal nil, @band.label
 
         @band.post("http://roar.example.com/bands", "application/xml")
-        assert_equal "Strung Out", @band.name
-        assert_equal "n/a", @band.label
+        assert_equal "STRUNG OUT", @band.name
+        assert_equal nil, @band.label
       end
     end
 
@@ -90,16 +85,16 @@ class Band
         @band.name   = "Strung Out"
         @band.label  = "Fat Wreck"
         @band.put("http://roar.example.com/bands/strungout", "application/xml")
-        assert_equal "Strung Out", @band.name
-        assert_equal "Fat Wreck", @band.label
+        assert_equal "STRUNG OUT", @band.name
+        assert_equal "FAT WRECK", @band.label
       end
     end
 
     describe "#patch" do
       it 'does something' do
         @band.label  = 'Fat Mike'
         @band.patch("http://roar.example.com/bands/strungout", "application/xml")
-        assert_equal 'Fat Mike', @band.label
+        assert_equal 'FAT MIKE', @band.label
       end
     end