Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing meta option does not work for JSONAPI #196

Closed
desheikh opened this issue Jul 21, 2016 · 2 comments
Closed

passing meta option does not work for JSONAPI #196

desheikh opened this issue Jul 21, 2016 · 2 comments

Comments

@desheikh
Copy link

Calling to_hash on a representer with ("meta" => {"foo" => "bar"}} does not render the meta attributes.

It looks like the implementation partially exists but is missing actually making the call and returning the response: https://github.com/apotonick/roar/blob/master/lib/roar/json/json_api.rb#L166

@KonstantinKo
Copy link

KonstantinKo commented Aug 29, 2016

I second this request. The README mentioned, that parsing meta is not yet implemented. But it appears that rendering meta information doesn't work either.
When just giving a meta key in the options it just gets ignored like @desheikh said.

When I insert a meta do block into the test representer, I get the error undefined local variable or method 'format_engine' for #<Class:…

Yes, this is definitely needed. For example for rendering a collection with pagination - similar to your blog post, @apotonick.

Please add this feature ❤️

myabc added a commit to myabc/roar that referenced this issue Dec 9, 2016
Fixes trailblazer#196

Signed-off-by: Alex Coles <alex@alexbcoles.com>
myabc added a commit to myabc/roar that referenced this issue Dec 10, 2016
Fixes trailblazer#196

Signed-off-by: Alex Coles <alex@alexbcoles.com>
@myabc
Copy link
Contributor

myabc commented Dec 10, 2016

This issue was moved to trailblazer/roar-jsonapi#4

@myabc myabc closed this as completed Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants