Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codefriar/misc fixes #10

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Codefriar/misc fixes #10

merged 3 commits into from
Oct 15, 2020

Conversation

codefriar
Copy link
Contributor

What does this PR do?

Fixes #8 and #9.
Adds some additional docs to the Readme.md on how to enable platform cache trials for sandbox orgs.

What issues does this PR fix or reference?

#8 #9
#
#7 #6

The PR fulfills these requirements:

[x] Tests for the proposed changes have been added/updated.
[x] Code linting and formatting was performed.

From fieldsets.

fixes #8
fixes #9
Adding Instructions for setting up Platform Cache on DE / Sandbox orgs.
Also fixes a mispelling in a comment in apexclassutilities
This was referenced Oct 15, 2020
@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   96.69%   96.69%           
=======================================
  Files          36       36           
  Lines        1242     1242           
=======================================
  Hits         1201     1201           
  Misses         41       41           
Flag Coverage Δ
#Apex 96.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...default/classes/Shared Code/ApexClassUtilities.cls 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f31660...552fbd4. Read the comment docs.

@msrivastav13
Copy link
Contributor

You would want to remove the below fields as well from the permission set.

Account.DandbCompanyId
Account.Jigsaw
Contact.CleanStatus
Contact.Jigsaw

I reviewed the list here. Removing this removes data.com license dependency.

Copy link
Contributor

@msrivastav13 msrivastav13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can remove some more fields from the permission sets, this looks good!

From two permission sets.
@codefriar
Copy link
Contributor Author

If we can remove some more fields from the permission sets, this looks good!

@msrivastav13 Good catch. Didn't know they were documented! New commit just added that removes those fields as well.

@codefriar codefriar merged commit 2f19b53 into master Oct 15, 2020
@codefriar codefriar deleted the codefriar/miscFixes branch October 15, 2020 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data.com fields required in Sandbox.
3 participants