Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

bump dependencies #155

Merged
merged 1 commit into from Feb 22, 2021
Merged

bump dependencies #155

merged 1 commit into from Feb 22, 2021

Conversation

julianduque
Copy link
Contributor

What does this PR do?

Update npm dependencies

What issues does this PR fix or reference?

All the dependabot issues.

The PR fulfills these requirements:

[x] Tests for the proposed changes have been added/updated.
[x] Code linting and formatting was performed.

@julianduque julianduque requested a review from a team as a code owner February 18, 2021 18:57
@julianduque julianduque marked this pull request as draft February 18, 2021 18:57
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #155 (dd7e1bd) into main (f7fb380) will decrease coverage by 4.33%.
The diff coverage is 90.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   97.22%   92.88%   -4.34%     
==========================================
  Files           6        8       +2     
  Lines          72      225     +153     
==========================================
+ Hits           70      209     +139     
- Misses          2       16      +14     
Flag Coverage Δ
Apex 92.88% <90.84%> (-4.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...app/main/default/classes/VehicleTriggerHandler.cls 83.33% <83.33%> (ø)
force-app/main/default/classes/TriggerHandler.cls 92.24% <92.24%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fb380...b3ed1bb. Read the comment docs.

@julianduque julianduque marked this pull request as ready for review February 18, 2021 19:22
"eslint": "^7.19.0",
"eslint-plugin-jest": "^24.1.3",
"husky": "^4.3.8",
"@salesforce/sfdx-lwc-jest": "^0.11.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for v51.0 it is still advised to use v0.10.4. The team maintaining @salesforce/sfdx-lwc-jest has messed up a version.

We are still using v0.10.4 for all other apps so let's keep that!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AH!!! Love the new --skipApiVersionCheck! I think that decouples version number! This looks good then!

Copy link
Contributor

@crcastle crcastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

I tested it with both Node ~12 and ~14.

Tested by doing the following with both node versions

npm i
npm run test
cd scripts && npm i
node ecarsDeploy.js

After deploy I checked that PDF generation, push notifications, and real-time dashboard worked as expected. Nice job!

@julianduque julianduque merged commit 095ea10 into main Feb 22, 2021
@julianduque julianduque deleted the jduque/update-deps branch February 22, 2021 14:53
rkponnam1979 referenced this pull request in rkponnam1979/ecars Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants