-
Notifications
You must be signed in to change notification settings - Fork 129
Conversation
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 97.22% 92.88% -4.34%
==========================================
Files 6 8 +2
Lines 72 225 +153
==========================================
+ Hits 70 209 +139
- Misses 2 16 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
"eslint": "^7.19.0", | ||
"eslint-plugin-jest": "^24.1.3", | ||
"husky": "^4.3.8", | ||
"@salesforce/sfdx-lwc-jest": "^0.11.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for v51.0 it is still advised to use v0.10.4
. The team maintaining @salesforce/sfdx-lwc-jest
has messed up a version.
We are still using v0.10.4
for all other apps so let's keep that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AH!!! Love the new --skipApiVersionCheck
! I think that decouples version number! This looks good then!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I tested it with both Node ~12 and ~14.
Tested by doing the following with both node versions
npm i
npm run test
cd scripts && npm i
node ecarsDeploy.js
After deploy I checked that PDF generation, push notifications, and real-time dashboard worked as expected. Nice job!
What does this PR do?
Update npm dependencies
What issues does this PR fix or reference?
All the dependabot issues.
The PR fulfills these requirements:
[x] Tests for the proposed changes have been added/updated.
[x] Code linting and formatting was performed.