Jest tests for Apex recipes #58
Conversation
| const buttonEl = element.shadowRoot.querySelector('lightning-button'); | ||
| buttonEl.dispatchEvent(new CustomEvent('click')); | ||
|
|
||
| jest.runAllTimers(); |
There was a problem hiding this comment.
Is this line really necessary? runAllTimers will flush the macro-task queue but the only macro-task here is the one in flushPromises that hasn't been called yet.
| return new Promise(resolve => setImmediate(resolve)); | ||
| } | ||
|
|
||
| it('lists two contacts based on user input', () => { |
There was a problem hiding this comment.
For this case the two contacts aren't actually from the user input. They're hardcoded above in this test. Maybe something more like "renders contacts returned from imperative Apex method call".
| return new Promise(resolve => setImmediate(resolve)); | ||
| } | ||
|
|
||
| it('lists two contacts based on user input', () => { |
There was a problem hiding this comment.
This only renders a single contact. It's also not actually based on user input.
| const buttonEl = element.shadowRoot.querySelector('lightning-button'); | ||
| buttonEl.dispatchEvent(new CustomEvent('click')); | ||
|
|
||
| jest.runAllTimers(); |
There was a problem hiding this comment.
I'm skeptical about the need for fake timers in this test as well.
|
|
||
| const inputEl = element.shadowRoot.querySelector('lightning-input'); | ||
| inputEl.value = 'Taylor'; | ||
| inputEl.dispatchEvent(new CustomEvent('change')); |
There was a problem hiding this comment.
We're updating the input here to set the searchKey, which will be passed as a param to findContacts after the button is clicked, but we never use or verify the searchKey value.
It'd be nice to have a test case for that. Since findContacts is a Jest mock function we should be able to verify the parameters on the invocation.
| import { createElement } from 'lwc'; | ||
| import ApexWireMethodToProperty from 'c/apexWireMethodToProperty'; | ||
| import { registerLdsTestWireAdapter } from '@salesforce/wire-service-jest-util'; | ||
| import getContactList from '@salesforce/apex/ContactController.getContactList'; |
There was a problem hiding this comment.
Same comment as apexStaticSchema.test.js above. After upgrading to lwc-jest, import from lwc-jest and use registerApexTestWireAdapter.
| import { createElement } from 'lwc'; | ||
| import ApexWireMethodWithParams from 'c/apexWireMethodWithParams'; | ||
| import { registerLdsTestWireAdapter } from '@salesforce/wire-service-jest-util'; | ||
| import findContacts from '@salesforce/apex/ContactController.findContacts'; |
There was a problem hiding this comment.
Same comment as apexStaticSchema.test.js above. After upgrading to lwc-jest, import from lwc-jest and use registerApexTestWireAdapter.
force-app/main/default/lwc/apexWireMethodWithParams/__tests__/apexWireMethodWithParams.test.js
Show resolved
Hide resolved
| }); | ||
|
|
||
| describe('findContacts @wire data', () => { | ||
| it('with one record', () => { |
There was a problem hiding this comment.
What is the behavior you're verifying here? findContacts @wire data > with one record explains the scenario you're executing but not what you're expecting to happen.
There was a problem hiding this comment.
Description changed
|
|
||
| const inputEl = element.shadowRoot.querySelector('lightning-input'); | ||
| inputEl.value = 'Amy'; | ||
| inputEl.dispatchEvent(new CustomEvent('change')); |
There was a problem hiding this comment.
Similar to my comment in apexImperativeMethodWithParams.test.js, this user input does not affect the outcome of the test since we emit the same set of test data regardless of input.
It'd be great to have a test that verifies this input is passed along to the @wire. Try the findContactsAdapter.getLastConfig() API.
|
|
||
| describe('c-apex-imperative-method', () => { | ||
| beforeAll(() => { | ||
| jest.useFakeTimers(); |
| const buttonEl = element.shadowRoot.querySelector('lightning-button'); | ||
| buttonEl.dispatchEvent(new CustomEvent('click')); | ||
|
|
||
| jest.runAllTimers(); |
| const buttonEl = element.shadowRoot.querySelector('lightning-button'); | ||
| buttonEl.dispatchEvent(new CustomEvent('click')); | ||
|
|
||
| jest.runAllTimers(); |
|
|
||
| describe('c-apex-imperative-method-with-params', () => { | ||
| beforeAll(() => { | ||
| jest.useFakeTimers(); |
Fixes #16