Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the name shown to the user (client) to be the server name specified in the install script #491

Closed
bluetardis opened this issue Apr 25, 2017 · 10 comments

Comments

@bluetardis
Copy link

bluetardis commented Apr 25, 2017

OS / Environment

AWS

Summary of the problem

During install a server name can be specified in the script. (A query could also be made for a "friendly name".
Regardless of what is entered, the name used is "Algo" for:
AWS Console
Apple MobileConfig
(and probably others that I can't test)

Steps to reproduce the behavior

normal install

The way of deployment (cloud or local)

cloud

Expected behavior

use the specified server name or optionally a friendly name/tag

Actual behavior

Full log

@dguido
Copy link
Member

dguido commented Apr 25, 2017

Oops

@bluetardis
Copy link
Author

You guys are fast :-)
Whats the preferred way to donate? Patreon

@dguido
Copy link
Member

dguido commented Apr 25, 2017

Any way is fine! Thanks for reporting the bug.

@dguido
Copy link
Member

dguido commented Apr 26, 2017

Can you provide a screenshot of what you are referring to?

@bluetardis
Copy link
Author

bluetardis commented Apr 29, 2017

Here are some examples.

Step1 We do the install and give the server a name.

We override the default name of "Algo" with testing123
1 naming-server

Step 2 Here is an example of the name not being used for AWS

We can see that it names the server Algo It does this for all build regardless of the name enterered
2 bug-example-aws

Step 3 Client implications

At the client end the name shown to the user will be incorrect but its not always displayed as "Algo" Sometimes its "IKEv2 12.34.56.78 Algo".

Apple MobileConfig

In the username.mobileconfig file, the following lines indicates the expected result (the server name entered in step1). Currently this needs to be edited manually.

            <key>PayloadDisplayName</key>
            <string>testing123</string>

Windows

In the generated windows_username.ps1 file the following lines indicate the expected result (the server name entered in step1). Currently this needs to be edited manually.

Add-VpnConnection -name "testing123" -ServerAddress "12.34.56.78" -TunnelType IKEv2 -AuthenticationMethod MachineCertificate -EncryptionLevel Required
Set-VpnConnectionIPsecConfiguration -ConnectionName "testing123" -AuthenticationTransformConstants GCMAES128 -CipherTransformConstants GCMAES128 -EncryptionMethod AES128 -IntegrityCheckMethod SHA384 -DHGroup ECP256 -PfsGroup none

@bluetardis
Copy link
Author

Let me know if you need more clarification but i figured that was more useful than screen shots from client devices.

@dguido dguido removed the bug label Apr 29, 2017
@dguido
Copy link
Member

dguido commented May 2, 2017

This makes sense, but we're going to take a look at this after we finish the 1.0 milestone.

@jackivanov jackivanov added this to the 1.1 milestone Mar 27, 2018
@bkono
Copy link

bkono commented May 22, 2018

Found this issue while looking to see if I had missed a config step. It was bugging me, so I went ahead and made initial changes to line up with the output I had hoped to see. Mainly a starting point for a second convenience feature I added for myself, but I kept it separate, just in case this is along the lines of what you were looking to do. If it is, let me know and I'd be happy to clean it up, get some additional testing in and PR it back. master...bkono:feature/server-name-in-mobileconfig

@dguido
Copy link
Member

dguido commented May 22, 2018

Thanks! We're open to receiving a PR for it.

bkono added a commit to bkono/algo that referenced this issue May 23, 2018
…WS EC2

Normalized the various cloud_server_name entries to just
algo_server_name. Integrated algo_server_name into the mobileconfig
template as well as powershell. If a default name is provided, the
original behavior of IP_subject_alt_name will be used to avoid conflicts.
Also updated the Name tag in the cloudformation template to utilize the
StackName (which is based on the algo_server_name).
@bkono
Copy link

bkono commented May 23, 2018

Great. PR is pushed #959 with screenshots of expected behavior in the comments.

bkono added a commit to bkono/algo that referenced this issue Sep 3, 2018
…emplates

EC2 Name tag in the cfn stack, VPNName in client_windows.ps1 and the
mobileconfig files all make use of the algo_server_name with a default
of the original Algo VPN naming when the server name is left at default
algo or algo.local.
@dguido dguido added this to To do in Algo Development Feb 17, 2019
@dguido dguido moved this from To do to 1.0 in Algo Development Feb 18, 2019
@jackivanov jackivanov removed this from the 1.1 milestone Feb 23, 2019
@jackivanov jackivanov moved this from 1.0 to In progress in Algo Development Feb 26, 2019
@jackivanov jackivanov added this to the 1.0 milestone Mar 12, 2019
Algo Development automation moved this from In progress to Done Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants